Fix empty reusable maps in ThreadPool #687
Merged
+29
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
reviewed
Jan 11, 2026
Spartan322
reviewed
Jan 11, 2026
Spartan322
reviewed
Jan 11, 2026
wvpm
force-pushed
the
fix_empty_reusable_maps
branch
2 times, most recently
from
2130060 to
6c2f72f
Compare
Spartan322
previously approved these changes
Jan 14, 2026
Spartan322
reviewed
Jan 14, 2026
wvpm
force-pushed
the
fix_empty_reusable_maps
branch
from
6c2f72f to
a1a1e8a
Compare
Spartan322
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ThreadPool created empty vectors:
memory::FixedVector<fixed_point_t> reusable_country_map_0 { country_keys.size() };They have a fixed capacity but a size of 0. Subsequent indexing was out of bounds.
This PR fixes that by forcing you to either use
FixedVector::create_empty(capacity)or specify a way to initialise the values.The name
create_emptyis chosen to avoid accidental empty vector creation.